Dismissing Find bar then hitting Cmd-F immediately doesn't show bar again

[njx]

1. Cmd-F to show the Find bar
2. In quick succession, click in the document and hit Cmd-F again

Result: Find bar doesn't reopen, probably because it's still animating closed. Same occurs if you hit Esc instead of clicking in the document in step 2.

I seem to run into this frequently, probably because I'm used to dismissing Find to clear the current search and then hitting Cmd-F right away to start a new one.

[dangoor]

Reviewed low priority to @njx. I think you're the most likely to know how to work around this. If not, we can reassign.

[njx]

That's good - I'd probably also be the most likely to want to fix it :)

[njx]

I know this is low pri, but I hit it a lot and I imagine that people who type fast would be pretty annoyed with it. Nominating for 1.0.

[njx]

Spent a little time looking at this. The issue is that we use global jQuery searches (e.g. $("#foo")) everywhere in the find code, so while the old search bar is animating out, if you try to open a new search bar, various bits of code will still find the old search bar - in particular, the code that tries to set focus to the new search bar's input field will actually focus the old one instead (which causes the new one to close, since it autocloses when focus is set elsewhere). The fix is to always scope searches to the current modalbar - should be straightforward.

[njx]

I decided to stop working on this in isolation, and instead deal with it as part of Replace Across Multiple Files, because we want to refactor the Find UI to be common across Find/Replace and Find/Replace In Files anyway. See all the comments where I'm talking to myself in #7512.

[njx]

Note to self: it seems like there's a much worse bug in Find in Files in master with the 1750 shell, where if you hit Esc to get out of it and then immediately try to open it again, not only does it not open then, but it never opens any time afterward! This doesn't seem to repro with the current shell.

[njx]

Fixed awhile ago as part of the replace in files stuff. Closing.