Selecting in inline editor rule list sometimes throws exceptions, leaving blank editor

[peterflynn]

Set up a project like this:

styles1.css: div { color: red; }
styles2.css: div { color: blue }
(plus some HTML content containing a <div>)

1. Open inline editor for <div>. I assume this will start out showing the rule from styles1.css.
2. In the project tree, double-click styles_2_.css to open it as a full editor
3. Go back to the HTML file
4. Click the result for styles2.css to open it in the inline

Result:
Exception "Document for this path already in _openDocuments!" thrown by Document. Inline editor is left blank.

[peterflynn]

This is happening because the rule list hangs onto Documents for all the search results and then later hands one of those to an Editor. Per the ref-counting rules, that's not allowed; the choice is either:

a) Don't hang onto Documents, just have the rule list hang onto the paths. When an item is selected, then call DocumentManager.getDocumentForPath() to get or create a Document to hand the Editor.

b) Hang onto Documents, but addRef() each one when adding to the rule list, and removeRef() them when removed from the rule list (or when the inline widget is destroyed). This is probably a little more bug-prone than option A.

[tvoliter]

Investigating

[julianasuh]

4/05/12: Assigned to Peter

[peterflynn]

Confirmed fixed by pull #583.