Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

[Performance] Improvements for QuickView #4910

@redmunds

Description

@redmunds

These suggested improvement were split off of #4885.

  1. Current, line is scanned every time mouse moves more than 1 char. Then, delay 350ms before displaying popover. Seems like we could save some (a lot of?) processing by delaying first, then if mouse is still at same position, scan & display. Note that @peterflynn thinks there may have been a good reason it was done this way, so there may be some gotchas.
  2. We check char position to make sure it's in code to popover, but we don't bail out of the loop after we get past current position.
  3. Do not scan lines that are over a certain length. CodeMirror does this for code coloring and matching braces due to bad performance of minified files. I think a length of 1024 is a reasonable place to start.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions