Skip to content

Adding font and tagline as editable properties in Brand view#1133

Merged
bokelley merged 3 commits intoadcontextprotocol:mainfrom
pkras:feat-brand-edit-fields
Feb 26, 2026
Merged

Adding font and tagline as editable properties in Brand view#1133
bokelley merged 3 commits intoadcontextprotocol:mainfrom
pkras:feat-brand-edit-fields

Conversation

@pkras
Copy link
Contributor

@pkras pkras commented Feb 19, 2026

before:
Screenshot 2026-02-19 at 19 48 53

after:
Screenshot 2026-02-19 at 19 49 44

Adds editable fields for tagline/slogan, primary font, and secondary font
to the brand editor, and relabels the tone field to "tone of voice". These
fields were already in the schema and displayed in the viewer but had no
way to be populated via the UI.
@pkras pkras force-pushed the feat-brand-edit-fields branch from f32a4a2 to 1c47f7b Compare February 19, 2026 18:55
@bokelley
Copy link
Contributor

A few things to look at:

Fonts can't be cleared once set. If a user previously saved fonts and later wants to remove them, clearing both font fields won't work — the save logic only writes fonts when at least one field is non-empty, so the existing values from currentEditStatus?.brand_manifest get spread in and persist. You'd need to either always write the fonts object (using undefined or null to clear) or add an explicit delete mechanism.

Tone data loss. When loading, manifest.tone is handled as either a string or an object (manifest.tone?.voice), but on save it's always written back as a plain string. If tone was previously stored as an object with additional fields beyond voice, those get dropped silently. Worth confirming that's intentional.

Nit: The changeset description says "slogan" but the form label is "tagline" — should be consistent.

@bokelley bokelley merged commit 565fb86 into adcontextprotocol:main Feb 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants