Skip to content

Fix a brand and sub brand count on brand registry page#1132

Open
pkras wants to merge 3 commits intoadcontextprotocol:mainfrom
pkras:feat-fix-brand-registry
Open

Fix a brand and sub brand count on brand registry page#1132
pkras wants to merge 3 commits intoadcontextprotocol:mainfrom
pkras:feat-fix-brand-registry

Conversation

@pkras
Copy link
Contributor

@pkras pkras commented Feb 19, 2026

Adding backfill migration to fix local env as well

before:

Screenshot 2026-02-19 at 19 23 43

after:

Screenshot 2026-02-19 at 19 23 18

@pkras
Copy link
Contributor Author

pkras commented Feb 19, 2026

hold on with this one i think i found something else that does not add up

@bokelley
Copy link
Contributor

Code change looks correct. A few data issues in the migration worth cleaning up:

  • pfizer.com appears in both the master list and the independent list. The master UPDATE runs first and then gets overridden to independent — so Pfizer ends up as an independent brand. That seems wrong; Pfizer is a top-level house brand and should probably be master.
  • lilly.com appears twice in the independent list.
  • nbcuniversal.com is set to master in the first block, then immediately overridden to sub_brand of Comcast further down. The first assignment is harmless but it's confusing — if it belongs under Comcast, it shouldn't be in the master list at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants