Skip to content

Fix invalid headers#210

Merged
adamhathcock merged 2 commits intoadamhathcock:masterfrom
kenkendk:fix_invalid_headers
Mar 9, 2017
Merged

Fix invalid headers#210
adamhathcock merged 2 commits intoadamhathcock:masterfrom
kenkendk:fix_invalid_headers

Conversation

@kenkendk
Copy link
Copy Markdown
Contributor

@kenkendk kenkendk commented Mar 9, 2017

This fixes a bug introduced with 6be6ef0.

Bad news is that all zip files written with 0.15.1 are semi-broken.
That is, their filenames are garbled, but content is recoverable.

@kenkendk
Copy link
Copy Markdown
Contributor Author

kenkendk commented Mar 9, 2017

As far as I can see the code here is not used, so my panic was unjustified.

For some reason, the ZipHeader has an abstract Write method, and all the subclasses implement it, but none of them call it.
This would only cause problems if someone were to manually construct the items and call the write methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants