Workflow schema validation to the validate script#1014
Closed
aparna-ravindra wants to merge 27 commits intoactions:mainfrom
aparna-ravindra:workflow-schema-validation
Closed
Workflow schema validation to the validate script#1014aparna-ravindra wants to merge 27 commits intoactions:mainfrom aparna-ravindra:workflow-schema-validation
aparna-ravindra wants to merge 27 commits intoactions:mainfrom
aparna-ravindra:workflow-schema-validation
Conversation
It was `npm_token` before, but for GitHub it's `GITHUB_TOKEN`. This makes them be the same, all-cap case.
Update python-publish.yml
nix: add Nix action
Make NPM_TOKEN consistent with GITHUB_TOKEN
Improve maven.yml
| - run: npm publish | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{secrets.GITHUB_TOKEN}} | ||
| NODE_AUTH_TOKEN: ${{secrets.GITHUB_TOKEN}} No newline at end of file |
Contributor
There was a problem hiding this comment.
if there's no difference between the above lines, you can skip this file from the PR.
| with: | ||
| user: __token__ | ||
| password: ${{ secrets.PYPI_API_TOKEN }} | ||
| password: ${{ secrets.PYPI_API_TOKEN }} No newline at end of file |
added 2 commits
July 26, 2021 14:26
Comment on lines
+106
to
+107
| const workflowValidationErrors = workflowValidationResult.errors.map(e => e.toString()) | ||
| workflowErrors.errors = workflowErrors.errors.concat(workflowValidationErrors) |
Contributor
There was a problem hiding this comment.
these two statements can be clubbed together.
| const workflow = safeLoad(workflowFileContent); // Validate yaml parses without error | ||
|
|
||
| let workflowValidator = new validator(); | ||
| const workflowSchema = require("./workflow-schema.json"); |
Contributor
There was a problem hiding this comment.
How will this schema file be maintained and updated? If the schema goes out of date with what in production, then we will get false negatives. Hence it is very important to define the clear path for maintenance of this file.
cc @andymckay
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current "validate" script that runs on PR and Push validates the .properties.json files. This PR adds an additional validation to check the schema of the .yaml file.