Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
f30a83a
adding extra catch for download failure in composite actions
vmjoseph Mar 13, 2023
984978b
Merge branch 'main' into vmjoseph/slo-incident
vmjoseph Mar 13, 2023
f1bfabc
Adding infra error
vmjoseph Mar 17, 2023
93929ac
Merge branch 'main' into vmjoseph/slo-incident
vmjoseph Mar 17, 2023
b777345
Adding error handling centralizing
vmjoseph Mar 20, 2023
88cf005
updating try catch bubbling
vmjoseph Mar 28, 2023
4c6982b
cleaning up commits
vmjoseph Mar 28, 2023
3068f65
cleaning up commits
vmjoseph Mar 28, 2023
e70526a
cleaning up commits
vmjoseph Mar 28, 2023
c816333
updating bubbler
vmjoseph Mar 28, 2023
da6ceb1
cleaning up test files
vmjoseph Mar 28, 2023
4681f1d
Fixing linting errors
vmjoseph Mar 28, 2023
d8b1a84
updating exception bubble
vmjoseph Mar 29, 2023
290688f
reverting composite
vmjoseph Mar 29, 2023
1abe6db
updating catch to not exclude other exceptions
vmjoseph Mar 29, 2023
02835c2
removing uneeded import
vmjoseph Mar 29, 2023
6ceaa65
Update src/Runner.Worker/ActionRunner.cs
vmjoseph Mar 30, 2023
6fc0990
Update src/Runner.Worker/ActionManager.cs
vmjoseph Mar 30, 2023
083a491
Update src/Runner.Worker/ActionManager.cs
vmjoseph Mar 30, 2023
052bf12
Update src/Runner.Worker/ActionManager.cs
vmjoseph Mar 30, 2023
c03ba77
Update src/Runner.Worker/ActionManager.cs
vmjoseph Mar 30, 2023
051cdd0
moving download out of for loop; reverting exception wrap
vmjoseph Mar 30, 2023
0193f2e
Update src/Runner.Worker/ActionManager.cs
vmjoseph Apr 6, 2023
b44fdd1
Merge branch 'main' into vmjoseph/slo-incident
vmjoseph May 11, 2023
31544f3
Adding blank lines back
vmjoseph May 11, 2023
dc08dd8
Adding blank lines back
vmjoseph May 11, 2023
d4ce939
removing uneeded catch for download fail
vmjoseph May 11, 2023
371f3e0
adding var back for consistency
vmjoseph May 11, 2023
16943a9
formatting clean
vmjoseph May 11, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/Runner.Worker/ActionManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
using WebApi = GitHub.DistributedTask.WebApi;
using Pipelines = GitHub.DistributedTask.Pipelines;
using PipelineTemplateConstants = GitHub.DistributedTask.Pipelines.ObjectTemplating.PipelineTemplateConstants;
using GitHub.DistributedTask.WebApi;

namespace GitHub.Runner.Worker
{
Expand Down Expand Up @@ -101,7 +102,19 @@ public sealed class ActionManager : RunnerService, IActionManager
}
IEnumerable<Pipelines.ActionStep> actions = steps.OfType<Pipelines.ActionStep>();
executionContext.Output("Prepare all required actions");
var result = await PrepareActionsRecursiveAsync(executionContext, state, actions, depth, rootStepId);
PrepareActionsState result = new PrepareActionsState();
try
{
result = await PrepareActionsRecursiveAsync(executionContext, state, actions, depth, rootStepId);
}
catch (FailedToResolveActionDownloadInfoException ex)
{
// Log the error and fail the PrepareActionsAsync Initialization.
Trace.Error($"Caught exception from PrepareActionsAsync Initialization: {ex}");
executionContext.InfrastructureError(ex.Message);
executionContext.Result = TaskResult.Failed;
throw;
}
if (!FeatureManager.IsContainerHooksEnabled(executionContext.Global.Variables))
{
if (state.ImagesToPull.Count > 0)
Expand Down
8 changes: 0 additions & 8 deletions src/Runner.Worker/JobExtension.cs
Original file line number Diff line number Diff line change
Expand Up @@ -431,14 +431,6 @@ public async Task<List<IStep>> InitializeJob(IExecutionContext jobContext, Pipel
context.Result = TaskResult.Canceled;
throw;
}
catch (FailedToResolveActionDownloadInfoException ex)
{
// Log the error and fail the JobExtension Initialization.
Trace.Error($"Caught exception from JobExtenion Initialization: {ex}");
context.InfrastructureError(ex.Message);
context.Result = TaskResult.Failed;
throw;
}
catch (Exception ex)
{
// Log the error and fail the JobExtension Initialization.
Expand Down