Add GitHub Actions to publish helm chart#257
Merged
mumoshu merged 14 commits intoactions:masterfrom Jan 24, 2021
Merged
Conversation
Signed-off-by: David Young <davidy@funkypenguin.co.nz>
Signed-off-by: David Young <davidy@funkypenguin.co.nz>
Signed-off-by: David Young <davidy@funkypenguin.co.nz>
…nner-controller into add-ci-workflow
Signed-off-by: David Young <davidy@funkypenguin.co.nz>
Signed-off-by: David Young <davidy@funkypenguin.co.nz>
mumoshu
reviewed
Jan 24, 2021
| dindSidecarRepositoryAndTag: "docker:dind" | ||
| pullPolicy: IfNotPresent | ||
|
|
||
| kube_rbac_proxy: |
Collaborator
There was a problem hiding this comment.
Very nit but let me change this to kubeRBACProxy (lowerCamelCase) for consistency with other keys 🙏
Collaborator
|
@summerwind Could you enable GitHub Pages on this repository? The preferable branch is
|
Contributor
|
Enabled with |
Collaborator
|
@summerwind Thanks for quick response |
mumoshu
approved these changes
Jan 24, 2021
Collaborator
mumoshu
left a comment
There was a problem hiding this comment.
LGTM. Thank you so much for your contribution @funkypenguin!
Contributor
|
is it working? I am getting an error saying that the index.yaml does not exist. |
Contributor
Author
|
Looks like it's complaining that the release already exists, based on this
action log:
https://github.com/summerwind/actions-runner-controller/runs/1758828515?check_suite_focus=true
…On Wed, Jan 27, 2021 at 5:58 AM Puneeth ***@***.***> wrote:
is it working? I am getting an error saying that the index.yaml does not
exist.
➜ infra git:(feature/actions) ✗ helm repo add actions https://summerwind.github.io/action-runner-controller
Error: looks like "https://summerwind.github.io/action-runner-controller" is not a valid chart repository or cannot be reached: failed to fetch https://summerwind.github.io/action-runner-controller/index.yaml : 404 Not Found
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#257 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALUHTSSMEI5Q3U3XJ2AE3LS33YCBANCNFSM4WHAZV4A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @summerwind!
Here's a PR for some GitHub actions I commonly use to test and publish helm charts using GitHub pages. If you create a branch
gh-pages, then the action will publish your helm chart at https://summerwind.github.io/action-runner-controller (you can see https://geek-cookbook.github.io/actions-runner-controller for an example)I've also made a handful of improvements to the helm chart to support kube-score static analysis, and chart linting/publishing via the helm "ct" tool.
Happy to field suggestions / change requests! :)
Cheers!
D