feat: adding manager secret to Helm chart#240
Closed
callum-tait-pbx wants to merge 4 commits intoactions:masterfrom
callum-tait-pbx:feat/helm-manager-secret
Closed
feat: adding manager secret to Helm chart#240callum-tait-pbx wants to merge 4 commits intoactions:masterfrom callum-tait-pbx:feat/helm-manager-secret
callum-tait-pbx wants to merge 4 commits intoactions:masterfrom
callum-tait-pbx:feat/helm-manager-secret
Conversation
The auth config needs to be commented out by default as we don't want to deploy both configs empty. This may break stuff, so we want the user to actively uncomment the auth method they want instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Helm template for deploying the manager secret, @mumoshu creating a seperate PR for this as I think this can be merged quicker this way.
By default the different auth methods are commented out as I don't think we want to deploy the key regardless of if the value is blank. The user should actively uncomment the auth method they want to deploy if we are doing a generic deploy all of the keys under the
authSecretconfig