Add CSSStyleDeclaration injection API for parsed rule styles#97
Open
domenic wants to merge 2 commits intoacemir:masterfrom
Open
Add CSSStyleDeclaration injection API for parsed rule styles#97domenic wants to merge 2 commits intoacemir:masterfrom
domenic wants to merge 2 commits intoacemir:masterfrom
Conversation
🦋 Changeset detectedLatest commit: e61c941 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
This lets us remove the workaround from jsdom/jsdom#4089 |
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
styleDeclarationProviderabstraction to resolve the declaration constructor used when creating rulestyleobjectslib/index.js:getCSSStyleDeclaration()setCSSStyleDeclaration(CSSStyleDeclaration)resetCSSStyleDeclaration()setup()to acceptCSSStyleDeclarationand wire it via providercssstylefallback behavior by routing it through the same providerREADME.mdownWhy
Consumers like jsdom need to inject their own
CSSStyleDeclarationimplementation. Reassigningrequire("@acemir/cssom/lib/CSSStyleDeclaration").CSSStyleDeclarationis not reliable because multiple modules capture constructor references during module initialization.This PR provides an explicit integration point so parser-created rule declarations are consistently constructed with the consumer-provided class.
Validation
npm run buildsetup({ CSSStyleDeclaration })causes parsed rule styles to use the injected constructor