[mlir][dxsa] Add dcl_tessellator_partitioning instruction#127
Open
tagolog wants to merge 1 commit intoaccess-softek:dxsa-mlirfrom
Open
[mlir][dxsa] Add dcl_tessellator_partitioning instruction#127tagolog wants to merge 1 commit intoaccess-softek:dxsa-mlirfrom
tagolog wants to merge 1 commit intoaccess-softek:dxsa-mlirfrom
Conversation
asl
reviewed
May 8, 2026
| auto partitioningMode = DECODE_D3D11_SB_TESS_PARTITIONING(opcodeToken); | ||
| if (partitioningMode == D3D11_SB_TESSELLATOR_PARTITIONING_UNDEFINED || | ||
| partitioningMode > D3D11_SB_TESSELLATOR_PARTITIONING_FRACTIONAL_EVEN) { | ||
| return emitError(loc, "invalid tessellator partitioning mode"); |
Contributor
There was a problem hiding this comment.
I am wondering, if it would make sense in all these emitError() calls everywhere to show the actual invalid value (no need to elaborate on ranges, etc.):
return emitError(loc, "invalid tessellator partitioning mode ") << partitioningMode;Example: dxsa.dcl_tessellator_partitioning partitioning_integer Signed-off-by: Vladimir Shiryaev <tagolog@users.noreply.github.com>
b5ec8de to
00a163e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
dxsa.dcl_tessellator_partitioning partitioning_integer