Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions mlir/include/mlir/Dialect/DXSA/IR/DXSAOps.td
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,25 @@ def DXSA_GlobalFlagsAttr :
let assemblyFormat = "`<` $value `>`";
}

def DXSA_TessellatorDomain_Isoline : I32EnumAttrCase<"domain_isoline", 1>;
def DXSA_TessellatorDomain_Tri : I32EnumAttrCase<"domain_tri", 2>;
def DXSA_TessellatorDomain_Quad : I32EnumAttrCase<"domain_quad", 3>;

def DXSA_TessellatorDomain : I32EnumAttr<
"TessellatorDomain", "tessellator domain", [
DXSA_TessellatorDomain_Isoline,
DXSA_TessellatorDomain_Tri,
DXSA_TessellatorDomain_Quad
]> {
let cppNamespace = "::mlir::dxsa";
let genSpecializedAttr = 0;
}

def DXSA_TessellatorDomainAttr :
EnumAttr<DXSADialect, DXSA_TessellatorDomain, "tessellator_domain"> {
let assemblyFormat = "$value";
}

//===----------------------------------------------------------------------===//
// DXSA op definitions
//===----------------------------------------------------------------------===//
Expand Down Expand Up @@ -196,4 +215,21 @@ def DXSA_DclOutputControlPointCount :
let assemblyFormat = [{ $count attr-dict }];
}

def DXSA_DclTessellatorDomain : DXSA_Op<"dcl_tessellator_domain"> {
let summary = "declares the tessellator domain";
let description = [{
The `dxsa.dcl_tessellator_domain` operation declares the tessellator
domain.

Example:

```mlir
dxsa.dcl_tessellator_domain domain_quad
```
}];

let arguments = (ins DXSA_TessellatorDomainAttr:$domain);
let assemblyFormat = "$domain attr-dict";
}

#endif // DXSA_OPS
17 changes: 17 additions & 0 deletions mlir/lib/Target/DXSA/BinaryParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,12 @@ class DXBuilder {
builder, loc, builder.getI32IntegerAttr(count));
}

Instruction buildDclTessellatorDomain(uint32_t domain, Location loc) {
auto domainAttr = dxsa::TessellatorDomainAttr::get(
builder.getContext(), static_cast<dxsa::TessellatorDomain>(domain));
return dxsa::DclTessellatorDomain::create(builder, loc, domainAttr);
}

private:
MLIRContext *context;
ModuleOp module;
Expand Down Expand Up @@ -891,6 +897,14 @@ class Parser {
return builder.buildDclOutputControlPointCount(count, loc);
}

FailureOr<Instruction> parseDclTessellatorDomain(uint32_t opcodeToken,
Location loc) {
auto domain = DECODE_D3D11_SB_TESS_DOMAIN(opcodeToken);
if (domain == D3D11_SB_TESSELLATOR_DOMAIN_UNDEFINED)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are only 3 valid values. Perhaps we can check them explicitly here, and reject the rest?

return emitError(getLocation(), "tessellator domain cannot be zero");
return builder.buildDclTessellatorDomain(domain, loc);
}

OptionalParseResult parseDclInstruction(uint32_t opcodeToken, Location loc,
Instruction &out) {
FailureOr<Instruction> result;
Expand All @@ -907,6 +921,9 @@ class Parser {
case D3D11_SB_OPCODE_DCL_OUTPUT_CONTROL_POINT_COUNT:
result = parseDclOutputControlPointCount(opcodeToken, loc);
break;
case D3D11_SB_OPCODE_DCL_TESS_DOMAIN:
result = parseDclTessellatorDomain(opcodeToken, loc);
break;
default:
return std::nullopt;
}
Expand Down
7 changes: 7 additions & 0 deletions mlir/test/Target/DXSA/dcl_tessellator_domain.mlir
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// RUN: mlir-translate --import-dxsa-bin %S/inputs/dcl_tessellator_domain.bin | FileCheck %s

// CHECK: module {
// CHECK-NEXT: dxsa.dcl_tessellator_domain domain_isoline
// CHECK-NEXT: dxsa.dcl_tessellator_domain domain_tri
// CHECK-NEXT: dxsa.dcl_tessellator_domain domain_quad
// CHECK-NEXT: }
Binary file not shown.