Mitigate UB when subtracting pointers#124
Open
eleviant wants to merge 1 commit intoaccess-softek:mainfrom
Open
Mitigate UB when subtracting pointers#124eleviant wants to merge 1 commit intoaccess-softek:mainfrom
eleviant wants to merge 1 commit intoaccess-softek:mainfrom
Conversation
clang emits sdiv exact instruction, when subtracting pointers, assuming both of them belong to the same array and therefore are properly aligned. This is not the case, when we subtracting unrelated pointers, which may not be aligned to a type size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang emits sdiv exact instruction, when subtracting pointers, assuming both of them belong to the same array and therefore are properly aligned. This is not the case, when we subtracting unrelated pointers, which may not be aligned to a type size.