[mlir][dxsa] Add dcl_thread_group instruction#121
Open
tagolog wants to merge 1 commit intoaccess-softek:dxsa-mlirfrom
Open
[mlir][dxsa] Add dcl_thread_group instruction#121tagolog wants to merge 1 commit intoaccess-softek:dxsa-mlirfrom
tagolog wants to merge 1 commit intoaccess-softek:dxsa-mlirfrom
Conversation
asl
reviewed
May 1, 2026
| ConfinedAttr<I32Attr, [IntPositive, IntMaxValue<1024>]>:$x, | ||
| ConfinedAttr<I32Attr, [IntPositive, IntMaxValue<1024>]>:$y, | ||
| ConfinedAttr<I32Attr, [IntPositive, IntMaxValue<64>]>:$z); | ||
| let assemblyFormat = [{ $x `,` $y `,` $z attr-dict }]; |
Contributor
There was a problem hiding this comment.
bike schedding: maybe it would be better to use syntax outlining the grid better? E.g. dxsa.dcl_thread_group 8 x 8 x 1? or even like this: dxsa.dcl_thread_group <x: 8, y: 8, z: 1> explicitly showing mesh axis?
Author
There was a problem hiding this comment.
I've implemented the operation as the dxsa.dcl_thread_group [8, 8, 1]
asl
reviewed
May 1, 2026
asl
reviewed
May 1, 2026
asl
reviewed
May 1, 2026
Example: dxsa.dcl_thread_group [8, 8, 1] Signed-off-by: Vladimir Shiryaev <tagolog@users.noreply.github.com>
a89b52d to
d02c638
Compare
asl
reviewed
May 8, 2026
| dxsa.dcl_thread_group [8, 8, 1] | ||
| ``` | ||
| }]; | ||
| let arguments = (ins ConfinedAttr<I64ArrayAttr, [ArrayCount<3>]>:$dims); |
Contributor
There was a problem hiding this comment.
Maybe better to have DenseI64ArrayAttr here? Then you could have direct access to the underlying array w/o need to cast to Attributes for individual entries below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
dxsa.dcl_thread_group 8, 8, 1