[mlir][dxsa] Add dcl_indexable_temp instruction#120
Draft
tagolog wants to merge 1 commit intoaccess-softek:dxsa-mlirfrom
Draft
[mlir][dxsa] Add dcl_indexable_temp instruction#120tagolog wants to merge 1 commit intoaccess-softek:dxsa-mlirfrom
tagolog wants to merge 1 commit intoaccess-softek:dxsa-mlirfrom
Conversation
Example: dxsa.dcl_indexable_temp x0[23], 2 dxsa.dcl_indexable_temp x7[4096], 4 Signed-off-by: Vladimir Shiryaev <tagolog@users.noreply.github.com>
845ef23 to
0ecbd6a
Compare
asavonic
reviewed
May 1, 2026
|
|
||
| namespace { | ||
|
|
||
| /// Parse a register identifier of the form `<prefix><N>` (e.g. `x0`, `r3`). |
Contributor
There was a problem hiding this comment.
We should consider if custom syntax is worth adding at this point, or at all.
It looks good, but we have a lot of instructions to support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
dxsa.dcl_indexable_temp x0[23], 2
dxsa.dcl_indexable_temp x7[4096], 4