Skip to content

[mlir][dxsa] Refine dcl_global_flags instruction#119

Merged
tagolog merged 1 commit intoaccess-softek:dxsa-mlirfrom
tagolog:dxsa-mlir-dcl_global_flags-refinement
May 9, 2026
Merged

[mlir][dxsa] Refine dcl_global_flags instruction#119
tagolog merged 1 commit intoaccess-softek:dxsa-mlirfrom
tagolog:dxsa-mlir-dcl_global_flags-refinement

Conversation

@tagolog
Copy link
Copy Markdown

@tagolog tagolog commented Apr 30, 2026

Decouple MLIR enum values from the binary layout, drop the artificial 'none' case.

Example:
dxsa.dcl_global_flags <refactoringAllowed|forceEarlyDepthStencil>

@tagolog tagolog requested a review from asavonic April 30, 2026 22:12
@tagolog tagolog self-assigned this Apr 30, 2026
@tagolog tagolog requested a review from asl April 30, 2026 23:16
Copy link
Copy Markdown
Contributor

@asavonic asavonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread mlir/include/mlir/Dialect/DXSA/IR/DXSAOps.td Outdated
Comment thread mlir/lib/Target/DXSA/BinaryParser.cpp Outdated
Comment thread mlir/test/Target/DXSA/dcl_global_flags.mlir Outdated
@tagolog tagolog force-pushed the dxsa-mlir-dcl_global_flags-refinement branch from 68fae22 to d74beec Compare May 6, 2026 21:21
Decouple MLIR enum values from the binary layout, drop the artificial 'none' case.

Example:
  dxsa.dcl_global_flags <refactoringAllowed|forceEarlyDepthStencil>

Signed-off-by: Vladimir Shiryaev <tagolog@users.noreply.github.com>
@tagolog tagolog force-pushed the dxsa-mlir-dcl_global_flags-refinement branch from d74beec to 2f8ba42 Compare May 6, 2026 23:19
@tagolog tagolog merged commit 47303ee into access-softek:dxsa-mlir May 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants