Skip to content

Conversation

@tdruez
Copy link
Contributor

@tdruez tdruez commented Dec 9, 2024

Implementation for #103

Changes:

  • Add new is_reachable field on the VulnerabilityAnalysis model as a tri-boolean field: yes, no, unknown
  • Reachability column added in the "Vulnerability" tab.
  • Add filter by "Reachability" from the column header.
  • The is_reachable value can be set from the "Vulnerability analysis" modal form
  • Add a VulnerabilityAnalysis REST API endpoint.

Screenshot 2024-12-09 at 18 50 14
Screenshot 2024-12-09 at 19 00 24

@DennisClark
Copy link
Member

@tdruez the feature works very nicely in Staging Starship except for one problem I encountered with the filtering: Filters by All, Reachable, and Not reachable are working fine, but the Filter by Reachability not known returns everything (the same as All).

@tdruez
Copy link
Contributor Author

tdruez commented Dec 10, 2024

@DennisClark Thanks for the review. The "Reachability not known" filter is now fixed.

@tdruez tdruez merged commit 6b4c819 into main Dec 11, 2024
3 checks passed
@tdruez tdruez deleted the 103-reachability branch December 11, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants