Skip to content

Conversation

@lawrence-forooghian
Copy link
Contributor

@lawrence-forooghian lawrence-forooghian commented Jan 28, 2026

Description

This reflects the functionality implemented in ably/ably-js#2155, based on the DR and ably/specification#419. Written by Claude.

Checklist

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch AIT-280-LiveObjects-apply-on-ACK

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lawrence-forooghian lawrence-forooghian force-pushed the AIT-280-LiveObjects-apply-on-ACK branch from 489f859 to 1038704 Compare January 28, 2026 17:05
@lawrence-forooghian lawrence-forooghian added the review-app Create a Heroku review app label Jan 28, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-ait-280-liveo-dkbfrq January 28, 2026 17:07 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the AIT-280-LiveObjects-apply-on-ACK branch from 1038704 to 6dfce76 Compare January 28, 2026 17:07
@ably-ci ably-ci temporarily deployed to ably-docs-ait-280-liveo-dkbfrq January 28, 2026 17:07 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the AIT-280-LiveObjects-apply-on-ACK branch from 6dfce76 to b88c57e Compare January 28, 2026 19:39
@ably-ci ably-ci temporarily deployed to ably-docs-ait-280-liveo-dkbfrq January 28, 2026 19:40 Inactive
@lawrence-forooghian lawrence-forooghian added review-app Create a Heroku review app and removed review-app Create a Heroku review app labels Jan 28, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-ait-280-liveo-nbhngm January 28, 2026 19:52 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the AIT-280-LiveObjects-apply-on-ACK branch from b88c57e to 1ee26c2 Compare January 28, 2026 20:13
@ably-ci ably-ci temporarily deployed to ably-docs-ait-280-liveo-nbhngm January 28, 2026 20:13 Inactive
@lawrence-forooghian lawrence-forooghian marked this pull request as ready for review January 30, 2026 18:06
Copy link
Contributor

@GregHolmes GregHolmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment, but not a breaker.

When a client publishes an operation, the operation is applied to its local objects as soon as the operation is acknowledged by the Ably system. This means that when a mutation method's promise resolves, the operation has already been applied and you can immediately read the updated state.
</Aside>

<Aside data-type='important'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this Aside needed? If the user is trying to implement with Swift or Java, they'll have the language relevant to them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that perhaps if they're using JS as their "main" SDK and then just porting their code across to Swift and Kotlin, then they might not re-read all the documentation for those two as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

4 participants