-
Notifications
You must be signed in to change notification settings - Fork 46
[AIT-280] Update JS LiveObjects documentation for apply-on-ACK #3161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
489f859 to
1038704
Compare
1038704 to
6dfce76
Compare
6dfce76 to
b88c57e
Compare
b88c57e to
1ee26c2
Compare
This reflects the functionality implemented in [1], based on the DR [2] and spec [3]. Written by Claude. [1] ably/ably-js#2155 [2] https://ably.atlassian.net/wiki/spaces/LOB/pages/4671832082/LODR-054+SDK+apply+operations+on+ACK) [3] ably/specification#419
1ee26c2 to
8531f8b
Compare
GregHolmes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment, but not a breaker.
| When a client publishes an operation, the operation is applied to its local objects as soon as the operation is acknowledged by the Ably system. This means that when a mutation method's promise resolves, the operation has already been applied and you can immediately read the updated state. | ||
| </Aside> | ||
|
|
||
| <Aside data-type='important'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this Aside needed? If the user is trying to implement with Swift or Java, they'll have the language relevant to them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that perhaps if they're using JS as their "main" SDK and then just porting their code across to Swift and Kotlin, then they might not re-read all the documentation for those two as well.
Description
This reflects the functionality implemented in ably/ably-js#2155, based on the DR and ably/specification#419. Written by Claude.
Checklist