Fix lastArchivePath, lastFilepath memory management#86
Merged
abbeycode merged 1 commit intoabbeycode:v2.10from Nov 26, 2019
fillito:patch-1
Merged
Fix lastArchivePath, lastFilepath memory management#86abbeycode merged 1 commit intoabbeycode:v2.10from fillito:patch-1
abbeycode merged 1 commit intoabbeycode:v2.10from
fillito:patch-1
Conversation
The project can't be archived due to `-Wobjc-property-assign-on-object-type` flagging a potential memory management error defining `lastArchivePath` and `lastFilepath`. Both properties are defined as `assign` but they contain object references. A `copy` would probably work better in this case. ``` /Users/danielgarcia/.../Carthage/Checkouts/UnrarKit/Classes/URKArchive.mm:54:1: error: 'assign' property of object type may become a dangling reference; consider using 'unsafe_unretained' [-Werror,-Wobjc-property-assign-on-object-type] @Property (assign) NSString *lastArchivePath; ^ /Users/danielgarcia/.../Carthage/Checkouts/UnrarKit/Classes/URKArchive.mm:55:1: error: 'assign' property of object type may become a dangling reference; consider using 'unsafe_unretained' [-Werror,-Wobjc-property-assign-on-object-type] @Property (assign) NSString *lastFilepath; ^ 2 errors generated. ```
abbeycode
approved these changes
Nov 26, 2019
Owner
|
Thanks for this! Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project can't be archived due to
-Wobjc-property-assign-on-object-typeflagging a potential memory management error defininglastArchivePathandlastFilepathproperties.Both properties are defined as
assignbut they contain object references. Acopywould probably work better in this case.