test: add unit tests for DeviceCodeOAuthFlow by neo1027144-creator · Pull Request #739 · a2aproject/a2a-java

neo1027144-creator · 2026-03-12T19:24:00Z

Add unit tests for DeviceCodeOAuthFlow record class.

Test cases:

Construction with all fields populated
Null refreshUrl (optional field)
Empty scopes map
Null validation for required fields (deviceAuthorizationUrl, tokenUrl, scopes)
Record equality and hashCode consistency

Follows the same testing patterns as FileWithBytesTest.

Fixes #607

gemini-code-assist · 2026-03-12T19:24:12Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the robustness of the DeviceCodeOAuthFlow record by introducing a dedicated suite of unit tests. These tests validate the record's behavior across various construction scenarios, ensuring correct handling of both required and optional fields, proper null validation, and consistent equals and hashCode implementations. This work directly contributes to the stability and reliability of the OAuth flow mechanisms.

Highlights

Unit Test Introduction: Added comprehensive unit tests for the DeviceCodeOAuthFlow record class.
Test Coverage: Included test cases for full field population, null refreshUrl handling, empty scopes, null validation for required fields (deviceAuthorizationUrl, tokenUrl, scopes), and equals/hashCode consistency.
Pattern Adherence: Followed established testing patterns, similar to FileWithBytesTest.
Issue Resolution: Addressed and fixed issue [Bug]: Missing tests for DeviceCodeOAuthFlow #607.

Activity

The pull request was created, and no human activity has occurred yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds a comprehensive set of unit tests for the DeviceCodeOAuthFlow record class. The tests cover construction, null validation for required fields, handling of optional fields, and record equality. The implementation is solid. I've provided a couple of suggestions to make the tests even more robust: one to enhance the assertions in the empty scopes test for better consistency, and another to expand the equality test to include inequality checks, which will provide more complete validation of the record's behavior.

gemini-code-assist · 2026-03-12T19:25:54Z

spec/src/test/java/io/a2a/spec/DeviceCodeOAuthFlowTest.java

+        DeviceCodeOAuthFlow flow = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, null, Map.of());
+
+        assertNotNull(flow.scopes());
+        assertEquals(0, flow.scopes().size());


This test only asserts properties of the scopes field. For completeness and consistency with other tests in this class (like testConstruction_withAllFields), it's better to assert the state of all fields of the constructed object. This makes the test more robust against future regressions.

Map<String, String> emptyScopes = Map.of(); DeviceCodeOAuthFlow flow = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, null, emptyScopes); assertEquals(DEVICE_AUTH_URL, flow.deviceAuthorizationUrl()); assertEquals(TOKEN_URL, flow.tokenUrl()); assertNull(flow.refreshUrl()); assertEquals(emptyScopes, flow.scopes());

gemini-code-assist · 2026-03-12T19:25:54Z

spec/src/test/java/io/a2a/spec/DeviceCodeOAuthFlowTest.java

+    void testEquality_sameValues() {
+        DeviceCodeOAuthFlow flow1 = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, REFRESH_URL, SCOPES);
+        DeviceCodeOAuthFlow flow2 = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, REFRESH_URL, SCOPES);
+
+        assertEquals(flow1, flow2);
+        assertEquals(flow1.hashCode(), flow2.hashCode());
+    }


The test for equality is good, but it only covers the case where objects are equal. To make the test suite more robust and fully validate the behavior of the record's equals and hashCode methods, it's beneficial to also include checks for inequality. I suggest renaming the test to reflect its expanded scope and adding assertions for a case where the objects are expected to be unequal.

Note: You will need to add import static org.junit.jupiter.api.Assertions.assertNotEquals; for this suggestion.

void testEqualityAndHashCode() { DeviceCodeOAuthFlow flow1 = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, REFRESH_URL, SCOPES); DeviceCodeOAuthFlow flow2 = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, REFRESH_URL, SCOPES); DeviceCodeOAuthFlow flow3WithNullRefresh = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, null, SCOPES); // Test for equality with same values assertEquals(flow1, flow2); assertEquals(flow1.hashCode(), flow2.hashCode()); // Test for inequality with different values assertNotEquals(flow1, flow3WithNullRefresh); }

ehsavoie · 2026-04-01T08:46:24Z

@neo1027144-creator can you please fix the gemini code review

neo1027144-creator · 2026-04-01T12:19:36Z

Sorry for the delayed response — I've just addressed the review feedback.
Thanks for the reminder!

@ehsavoie

neo1027144-creator · 2026-04-01T12:26:57Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces unit tests for the DeviceCodeOAuthFlow class, covering object construction, parameter validation, and basic equality. The feedback suggests enhancing the test suite by adding a test for the immutability of the scopes map to ensure defensive copying and expanding the equality and hash code tests to include more comprehensive edge cases such as type mismatches and null checks.

gemini-code-assist · 2026-04-01T12:30:01Z

spec/src/test/java/io/a2a/spec/DeviceCodeOAuthFlowTest.java

+        assertEquals(TOKEN_URL, flow.tokenUrl());
+        assertNull(flow.refreshUrl());
+        assertEquals(emptyScopes, flow.scopes());
+    }


Consider adding a test case to verify that the scopes map is immutable. Records representing configuration should ideally be protected against external mutation of their internal state. Note that the current implementation of DeviceCodeOAuthFlow is missing a defensive copy of the scopes map, which this test would help identify.

} @Test void testScopesImmutability() { Map<String, String> mutableScopes = new java.util.HashMap<>(); mutableScopes.put("read", "Read access"); DeviceCodeOAuthFlow flow = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, REFRESH_URL, mutableScopes); // Modifying the original map should not affect the record if it performs a defensive copy mutableScopes.put("write", "Write access"); assertNotEquals(mutableScopes.size(), flow.scopes().size(), "Record should be immutable and perform a defensive copy of the scopes map"); }

gemini-code-assist · 2026-04-01T12:30:01Z

spec/src/test/java/io/a2a/spec/DeviceCodeOAuthFlowTest.java

+    void testEqualityAndHashCode() {
+        DeviceCodeOAuthFlow flow1 = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, REFRESH_URL, SCOPES);
+        DeviceCodeOAuthFlow flow2 = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, REFRESH_URL, SCOPES);
+        DeviceCodeOAuthFlow flow3WithNullRefresh = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, null, SCOPES);
+
+        // Test for equality with same values
+        assertEquals(flow1, flow2);
+        assertEquals(flow1.hashCode(), flow2.hashCode());
+
+        // Test for inequality with different values
+        assertNotEquals(flow1, flow3WithNullRefresh);
+    }


The equality and hash code tests are currently limited. For a record that serves as a core data carrier in the specification, it is important to verify that equality and hash code consistency hold for all fields, including optional ones, and that inequality is correctly handled for different field values and null/type mismatches.

@Test void testEqualityAndHashCode() { DeviceCodeOAuthFlow flow1 = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, REFRESH_URL, SCOPES); DeviceCodeOAuthFlow flow2 = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, REFRESH_URL, SCOPES); DeviceCodeOAuthFlow flow3 = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, null, SCOPES); DeviceCodeOAuthFlow flow4 = new DeviceCodeOAuthFlow(DEVICE_AUTH_URL, TOKEN_URL, null, SCOPES); // Test for equality and hashCode consistency assertEquals(flow1, flow2); assertEquals(flow1.hashCode(), flow2.hashCode()); assertEquals(flow3, flow4); assertEquals(flow3.hashCode(), flow4.hashCode()); // Test for inequality assertNotEquals(flow1, flow3); assertNotEquals(flow1, new DeviceCodeOAuthFlow("https://other.com", TOKEN_URL, REFRESH_URL, SCOPES)); assertNotEquals(flow1, null); assertNotEquals(flow1, "not a flow"); }

Test cases: - Construction with all fields populated - Null refreshUrl (optional field) - Empty scopes map with full field assertions - Null validation for required fields (deviceAuthorizationUrl, tokenUrl, scopes) - Record equality, hashCode consistency, and inequality edge cases - Scopes map immutability (defensive copy via Map.copyOf) Also fix: add Map.copyOf() defensive copy in DeviceCodeOAuthFlow compact constructor Fixes a2aproject#607

neo1027144-creator · 2026-04-01T13:12:52Z

/gemini review

gemini-code-assist bot reviewed Mar 12, 2026

View reviewed changes

neo1027144-creator force-pushed the issue-607 branch from 1da4049 to e751b3f Compare April 1, 2026 12:15

gemini-code-assist bot reviewed Apr 1, 2026

View reviewed changes

neo1027144-creator force-pushed the issue-607 branch from 355301e to ac9f5b3 Compare April 1, 2026 13:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add unit tests for DeviceCodeOAuthFlow#739

test: add unit tests for DeviceCodeOAuthFlow#739
neo1027144-creator wants to merge 1 commit intoa2aproject:mainfrom
neo1027144-creator:issue-607

neo1027144-creator commented Mar 12, 2026

Uh oh!

gemini-code-assist bot commented Mar 12, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Mar 12, 2026

Uh oh!

gemini-code-assist bot Mar 12, 2026

Uh oh!

ehsavoie commented Apr 1, 2026

Uh oh!

neo1027144-creator commented Apr 1, 2026

Uh oh!

neo1027144-creator commented Apr 1, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Apr 1, 2026

Uh oh!

gemini-code-assist bot Apr 1, 2026

Uh oh!

neo1027144-creator commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

neo1027144-creator commented Mar 12, 2026

Uh oh!

gemini-code-assist bot commented Mar 12, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

ehsavoie commented Apr 1, 2026

Uh oh!

neo1027144-creator commented Apr 1, 2026

Uh oh!

neo1027144-creator commented Apr 1, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

neo1027144-creator commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants