Skip to content

[FIX] Use correct primary key field in prompt count subquery #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harini-venkataraman merged 1 commit into from
Apr 7, 2026
Merged

[FIX] Use correct primary key field in prompt count subquery #1905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/prompt_studio/prompt_studio_core_v2/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def get_queryset(self) -> QuerySet | None:
ToolStudioPrompt.objects.filter(tool_id=OuterRef("pk"))
.order_by()
.values("tool_id")
.annotate(cnt=Count("id"))
.annotate(cnt=Count("prompt_id"))
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Consider using Count("*") for clarity

The fix is correct — prompt_id is the non-null primary key so Count("prompt_id") is semantically identical to COUNT(*). However, using Count("*") makes the intent explicit ("count every row in the group") and avoids any future confusion if a reader wonders why a specific field is named here rather than a simple row count.

Suggested change
.annotate(cnt=Count("prompt_id"))
.annotate(cnt=Count("*"))
Prompt To Fix With AI 
This is a comment left during a code review.
Path: backend/prompt_studio/prompt_studio_core_v2/views.py
Line: 118

Comment:
**Consider using `Count("*")` for clarity**

The fix is correct — `prompt_id` is the non-null primary key so `Count("prompt_id")` is semantically identical to `COUNT(*)`. However, using `Count("*")` makes the intent explicit ("count every row in the group") and avoids any future confusion if a reader wonders why a specific field is named here rather than a simple row count.

```suggestion
                .annotate(cnt=Count("*"))
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

.values("cnt")
)
qs = qs.select_related("created_by").annotate(
Expand Down