Caching Adjacency Matrix for faster edge lookup #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 97.31% 97.41% +0.09%
==========================================
Files 55 55
Lines 8455 8539 +84
==========================================
+ Hits 8228 8318 +90
+ Misses 227 221 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sbaldu
reviewed
Sep 15, 2023
sbaldu
reviewed
Sep 15, 2023
sbaldu
requested changes
Sep 22, 2023
nrkramer
reviewed
Sep 23, 2023
| }) != nodeSet.end()); | ||
| } | ||
|
|
||
| TEST(GraphTest, FindEdge_Test) { |
Collaborator
There was a problem hiding this comment.
Please add spacing in logical places between lines in this test. It's hard to read
Contributor
Author
There was a problem hiding this comment.
Done. Please review.
nrkramer
reviewed
Sep 23, 2023
Collaborator
nrkramer
left a comment
There was a problem hiding this comment.
Looks great so far!
Only one nit from me to maybe rename getCacheAdjMatrix() to cacheAdjMatrix()
nrkramer
approved these changes
Sep 24, 2023
Collaborator
nrkramer
left a comment
There was a problem hiding this comment.
All my comments have been addressed. Thanks!
sbaldu
approved these changes
Sep 24, 2023
Collaborator
|
Looks good to me as well |
ZigRazor
approved these changes
Sep 25, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for Issue #340 .