Open
Conversation
in the REST response on /v2/ on some occasions when the storage backend is inaccessible
too optimistic in that registries can get ready on start and the unready again because storage never started to work
something like 30s start to fail because storage didn't go up
6274bc6 to
8e502e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have https://docs.docker.com/registry/configuration/#health enabled for the s3 driver but no https://docs.docker.com/registry/configuration/#debug endpoint. When storage fails the endpoint can provide details to why registry is unready, such as GCS authentication or connection refused on minio port 9000.
The registry container doesn't have curl so extracting this information is nontrivial. I'm relucant to add another port to forward. Running a curl job in-cluster is a practical option, which is why the debug server is binding to 0.0.0.0 instead of localhost.