Add utilities for cacheable layers in docker builds#33
Merged
Conversation
and the versioned file to not be overwritten at COPY npm-monorepo/ci/ in Dockerfile
Contributor
Author
|
Ready for merge + publish, but how do we adopt the tests? Can we run them in build-contract's build-contract? |
9798d29 to
71a1717
Compare
i.e. called through `build-contract` from anywhere, like with npm install -g'd build-contract.
solsson
added a commit
to solsson/npm-monorepo-example
that referenced
this pull request
Apr 23, 2018
Contributor
Author
|
Built |
Contributor
Author
|
@atamon You'll probably - unless we take a hard look at our npm-monorepo deps cause output like: A workaround is to monkeypatch package-lock.json. Not a big deal security-wise for monorepo deps, but annoying enough. |
so that build-contract terminates, though no longer with colors in the error message.
Contributor
Author
|
In-docker (not only in-cluster) build-contract also fails due to monorepo npm pack not executing the |
solsson
added a commit
that referenced
this pull request
May 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With CI builds or local round trips we want the following layers cached
Still WIP. We should port the tests from https://github.com/solsson/npm-monorepo-example to build-contracts here.