Skip to content
This repository was archived by the owner on Jul 15, 2019. It is now read-only.

improved performance of getProtocol() and htmlDecode() #50

Open
adon-at-work wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improved performance of getProtocol() and htmlDecode() #50

adon-at-work wants to merge 1 commit into from

Conversation

@adon-at-work
Copy link
Contributor

@adon-at-work adon-at-work commented Aug 21, 2015

According to the benchmark,

  • speed of getProtocol() is now 8.69x faster (or 3.53x faster given samples collected from flickr)
  • speed of htmlDecode(), when used standalone, is 1.28x faster

This performance improvement is significant, and this will benefit those filters involving URIs (since yubl() is using getProtocol()).

@adon-at-work
Copy link
Contributor Author

adon-at-work commented Aug 23, 2015

@neraliu, please help review and merge. thanks :)
(secure-handlebars can get run-time performance improvement. html-purify will also run faster after this PR.)

@adon-at-work adon-at-work force-pushed the improve-performance branch 2 times, most recently from 5335711 to f0c26c4 Compare October 1, 2015 00:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adon-at-work