net: fix SBE1V1K TFTP behind Qualcomm PPE ACL - #6
Open
zhouzhiwen2000 wants to merge 1 commit into
Open
Conversation
The Qualcomm NSS driver drops unmatched UDP traffic and only installs its TFTP exception behind the undefined CONFIG_TFTP_PORT symbol. With the lwIP network stack, the client also ignores tftpsrcp and selects an ephemeral port, so TFTP replies never reach EDMA. Install the ACL whenever tftpboot is enabled and teach the lwIP client to bind the tftpsrcp port selected by the NSS driver. Validated with the sbe1v1k_chainloader_defconfig build and chainloader FIT packaging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tftpbootis enabledtftpsrcpin the U-Boot lwIP TFTP wrapper so the client port matches the PPE ACLProblem
The NSS/PPE setup allows DHCP ports 67 and 68, then drops all remaining UDP traffic. The TFTP exception was guarded by the undefined
CONFIG_TFTP_PORTsymbol, so it was never installed.This board uses the lwIP network stack, whose TFTP client selected an ephemeral UDP port and ignored
tftpsrcp. TFTP RRQs reached the server, but OACK and DATA responses were dropped by PPE before reaching EDMA.Validation
make sbe1v1k_chainloader_defconfigmake CROSS_COMPILE=aarch64-linux-gnu- -j8u-boot.bingit diff --checkHardware validation passed on an SBE1V1K: the rebuilt chainloader successfully completed a TFTP transfer through the Qualcomm PPE/EDMA path.