Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Walkthrough감정 기록 등록 프레젠터에서 감정 상세 바텀 시트 해제 이벤트 처리 로직을 변경했습니다. 바텀 시트 해제 시 committedEmotionCode가 null이면 selectedEmotionCode와 selectedEmotionMap을 초기화하고, null이 아니면 이전 선택 상태를 복원하며 항상 isEmotionDetailBottomSheetVisible를 false로 설정합니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@feature/record/src/main/kotlin/com/ninecraft/booket/feature/record/register/RecordRegisterPresenter.kt`:
- Around line 272-278: The dismiss branch for
RecordRegisterUiEvent.OnEmotionDetailBottomSheetDismiss currently only resets
selectedEmotionCode/selectedEmotionMap when committedEmotionCode == null,
leaving a stale selection when a user opened the detail sheet for a different
emotion and dismissed without committing; update this handler so that when
committedEmotionCode != null you restore the UI selection to the committed state
(set selectedEmotionCode back to committedEmotionCode and restore
selectedEmotionMap to the map representing the committed emotion) before setting
isEmotionDetailBottomSheetVisible = false, ensuring the temporary selection
(e.g., SAD) is not preserved after dismiss.
...cord/src/main/kotlin/com/ninecraft/booket/feature/record/register/RecordRegisterPresenter.kt
Show resolved
Hide resolved
- 이미 커밋된 감정이 있는 상태에서 다른 감정 선택 후 커밋 없이 dismiss했을 때, 커밋된 감정을 누르면 수정 다이얼로그가 재노출되는 문제 해결
🔗 관련 이슈
📙 작업 설명
🧪 테스트 내역 (선택)
📸 스크린샷 또는 시연 영상 (선택)
Summary by CodeRabbit
릴리스 노트