test(eth/fetcher): tune flaky test #18508#2342
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR tweaks timing in the eth/fetcher test suite to reduce flakiness (ref ethereum#18508) by extending the “no import should happen” wait window in verifyImportEvent.
Changes:
- Increase the negative-case
verifyImportEventtimeout from 10ms to 20ms to better accommodate scheduling variability.
| select { | ||
| case <-imported: | ||
| t.Fatalf("import invoked") | ||
| case <-time.After(10 * time.Millisecond): | ||
| case <-time.After(20 * time.Millisecond): | ||
| } |
Proposed changes
Ref: ethereum#18508
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that