fix: resolve multiple UI and code quality issues (#688, #734, #758, #778)#837
Closed
MrRealORG wants to merge 11 commits into
Closed
fix: resolve multiple UI and code quality issues (#688, #734, #758, #778)#837MrRealORG wants to merge 11 commits into
MrRealORG wants to merge 11 commits into
Conversation
docs: correct OpenCode repository URL in README files
…-qrcode docs: update community group chat QR code
…-qrcode docs: update community WeChat QR codes
…omiMiMo#734, XiaomiMiMo#758, XiaomiMiMo#778) - XiaomiMiMo#734: SessionPrune.resetThresholds now clears writerFailures counter to prevent stale failure counts from carrying over across threshold reset cycles - XiaomiMiMo#688: Improve light mode text contrast in theme.css: --text-weak: #8f8f8f -> #5f5f5f (WCAG AA pass) --text-weaker: #c7c7c7 -> #8a8a8a (WCAG AA pass) - XiaomiMiMo#758: mimo -c no longer hangs on blank screen when no sessions exist; navigates to home with a warning toast instead of staying on invalid "dummy" session route - XiaomiMiMo#778: Update bug report template to reference "MiMo Code" instead of "OpenCode" and fix Discord link in config.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes four open issues in a single PR:
#734 — SessionPrune.resetThresholds leaves stale checkpoint writer failure counters
resetThresholds(sessionID)clearedcrossedandmaxCrossedbut leftwriterFailuresuntouched. A session entering a fresh checkpoint threshold cycle could inherit the previous consecutive writer failure count, causing it to hit the retry cap earlier than expected.Fix: Add
writerFailures.delete(sessionID)toresetThresholds().#688 — Light mode settings page has low-contrast text
CSS variables
--text-weak(#8f8f8f) and--text-weaker(#c7c7c7) in light mode failed WCAG AA contrast requirements against the ~#f8f8f8 background.Fix:
--text-weak:#8f8f8f→#5f5f5f(contrast ratio ~6.4:1, passes WCAG AA)--text-weaker:#c7c7c7→#8a8a8a(contrast ratio ~3.8:1, improved readability)#758 — TUI hangs on blank screen when
mimo -chas no prior sessionsWhen
mimo -cwas run with no prior sessions, the TUI setsessionID: "dummy"as a placeholder route. The server rejected this invalid ID, and since no session existed to navigate to, the UI remained stuck on a blank screen.Fix: When the session list loads (partial/complete) and no session is found to continue, navigate to home with a warning toast instead of staying stuck.
#778 — Bug report template references "OpenCode" instead of "MiMo Code"
The issue template still referenced the upstream fork name.
Fix:
bug-report.yml: field id, label, and description now reference "MiMo Code"config.yml: replaced OpenCode Discord link with MiMo Code GitHub Discussions linkTest Plan
mimo -cin a fresh directory shows toast and navigates to home instead of hangingresetThresholdsclears writer failure counter (unit test)Closes #688, Closes #734, Closes #758, Closes #778