Trac/62757#12526
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @NutanLagad. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Reduce the maximum old space size for Node.js from 6144 to 4096. Let's make sure this change is actually necessary.
|
Given that jQuery UI is mostly in maintenance mode now, I would think there should not be very many changes here, but it says that the diff is +18,838 lines added, -1,887 lines removed? Looking at it more closely, the file |
|
@siliconforks Yep, It's the entire dist/jquery-ui.js file as of now. Working on separating it out so that it matches what was previusly shipped |
Instead of the full build, this uses https://jqueryui.com/download/ and has only the "core" items checked. URL for this build: https://jqueryui.com/download/#!version=1.14.2&components=111111111111000000000000000000000000000000000000
The jQuery UI Builder does not include $.ui.plugin by default, this restores it by copying the content from https://github.com/jquery/jquery-ui/blob/1.14.2/ui/plugin.js
In order to lower the risk with this change, jQuery UI is set to be in back compat mode to keep support for the jQuery UI 1.11 API. The build for `core.js` is https://jqueryui.com/download/#!version=1.14.2&components=111111111111000000000000000000000000000000000000 with the addition of the deprecated $.ui.plugin from https://github.com/jquery/jquery-ui/blob/1.14.2/ui/plugin.js. All other files are based off of files in https://github.com/jquery/jquery-ui/tree/1.14.2/ui. Developed in: #12526 Props pankaj.sakaria, mgol, mukesh27, ozgursar, siliconforks, joedolson, OllieJones, wildworks, jorbin. Fixes #62757. git-svn-id: https://develop.svn.wordpress.org/trunk@62747 602fd350-edb4-49c9-b593-d223f7449a82
In order to lower the risk with this change, jQuery UI is set to be in back compat mode to keep support for the jQuery UI 1.11 API. The build for `core.js` is https://jqueryui.com/download/#!version=1.14.2&components=111111111111000000000000000000000000000000000000 with the addition of the deprecated $.ui.plugin from https://github.com/jquery/jquery-ui/blob/1.14.2/ui/plugin.js. All other files are based off of files in https://github.com/jquery/jquery-ui/tree/1.14.2/ui. Developed in: WordPress/wordpress-develop#12526 Props pankaj.sakaria, mgol, mukesh27, ozgursar, siliconforks, joedolson, OllieJones, wildworks, jorbin. Fixes #62757. Built from https://develop.svn.wordpress.org/trunk@62747 git-svn-id: http://core.svn.wordpress.org/trunk@62031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Builds off of #10893.
Trac Ticket: https://core.trac.wordpress.org/ticket/62757
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.