Administration: Remove unused font-weight tokens#12524
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
left a comment
There was a problem hiding this comment.
I am not an active committer, but this LGTM and follows my own findings shared previously that these are currently unused and inconsistent with the font weights being introduced to Gutenberg in WordPress 7.1, and that new usage should ideally use the new CSS properties instead.
Remove the unused `$font-weight-regular` and `$font-weight-medium` Sass variables from the admin color scheme tokens. Neither variable has a consumer, so this does not change any generated CSS or runtime styling. These tokens are also inconsistent with the font weights being introduced to the Gutenberg project in WordPress 7.1, where new usage should rely on the new CSS custom properties instead. Developed in #12524. Props ciampo, aduth, tyxla. Fixes #65629. git-svn-id: https://develop.svn.wordpress.org/trunk@62755 602fd350-edb4-49c9-b593-d223f7449a82
Related: WordPress/gutenberg#80093
Removes the unused
$font-weight-regularand$font-weight-mediumSass variables from the admin color scheme tokens. Neither variable has a consumer, so this does not change generated CSS or runtime styling.Trac ticket: https://core.trac.wordpress.org/ticket/65629
Testing Instructions
npm run grunt -- colors --dev.Use of AI Tools
AI assistance: Yes
Tool(s): OpenAI Codex
Model(s): GPT-5
Used for: Repository research, implementation, verification, and PR preparation.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.