Add option to disable spawnv define#301
Merged
Merged
Conversation
Contributor
Author
Contributor
|
I would prefer to have the script detect the platform and do the right behavior, rather than add an option. |
Contributor
Author
Fair enough, Ill have a look |
5ef8b14 to
93e619a
Compare
Contributor
Author
|
The new configure doesnt require a manual option anymore, I tested it on Mingw x64 and Mingw UCRT x64 and it now configures and compiles on both without a hitch |
Contributor
|
There's probably a cleaner way to do this with autconf (see https://stackoverflow.com/questions/46704731/check-value-of-c-define-with-autoconf) but this seems good enough for now, thanks |
Contributor
Author
|
Ah yeah that SO answer looks cleaner for sure, but thanks for merging it anyway. It will make our build process much smoother. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps UCRT mingw users workaround the problem mentioned in #300