Skip to content

Add option to disable spawnv define#301

Merged
evanmiller merged 2 commits into
WizardMac:devfrom
JorisGoosen:disableSpawnvFix
Sep 21, 2023
Merged

Add option to disable spawnv define#301
evanmiller merged 2 commits into
WizardMac:devfrom
JorisGoosen:disableSpawnvFix

Conversation

@JorisGoosen
Copy link
Copy Markdown
Contributor

Helps UCRT mingw users workaround the problem mentioned in #300

@JorisGoosen
Copy link
Copy Markdown
Contributor Author

@evanmiller ?

@evanmiller
Copy link
Copy Markdown
Contributor

I would prefer to have the script detect the platform and do the right behavior, rather than add an option.

@JorisGoosen
Copy link
Copy Markdown
Contributor Author

I would prefer to have the script detect the platform and do the right behavior, rather than add an option.

Fair enough, Ill have a look

@JorisGoosen
Copy link
Copy Markdown
Contributor Author

The new configure doesnt require a manual option anymore, I tested it on Mingw x64 and Mingw UCRT x64 and it now configures and compiles on both without a hitch

@evanmiller
Copy link
Copy Markdown
Contributor

There's probably a cleaner way to do this with autconf (see https://stackoverflow.com/questions/46704731/check-value-of-c-define-with-autoconf) but this seems good enough for now, thanks

@evanmiller evanmiller merged commit 4926250 into WizardMac:dev Sep 21, 2023
@JorisGoosen
Copy link
Copy Markdown
Contributor Author

Ah yeah that SO answer looks cleaner for sure, but thanks for merging it anyway. It will make our build process much smoother.

@hpoettker hpoettker mentioned this pull request Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants