Skip to content

[WIP] Add i18n feature and Japanese Translation#3

Merged
aarranz merged 1 commit into
Wirecloud:developfrom
fisuda:i18n-feature
Apr 17, 2019
Merged

[WIP] Add i18n feature and Japanese Translation#3
aarranz merged 1 commit into
Wirecloud:developfrom
fisuda:i18n-feature

Conversation

@fisuda
Copy link
Copy Markdown
Contributor

@fisuda fisuda commented Apr 13, 2019

Hi @aarranz ,

I added i18n feature to this widget. Would you please review this PR? Please give me an adivace if there is more better implementation than this on.

Thanks

@aarranz
Copy link
Copy Markdown
Member

aarranz commented Apr 17, 2019

Hi @fisuda,

Thank you very much for this contribution. Implementation is more than perfect for now. Moreover, this pull requests fixes issue #2.

Best Regards,
Álvaro

@aarranz
Copy link
Copy Markdown
Member

aarranz commented Apr 17, 2019

I'm going to merge this, that way I will be able to add Spanish translation and test if there is something to be done before releasing v1.0.3. In any case, my idea is to release version 1.0.3 just with the new translations.

Thank you very much.

@aarranz aarranz merged commit 9632bf9 into Wirecloud:develop Apr 17, 2019
@fisuda
Copy link
Copy Markdown
Contributor Author

fisuda commented Apr 17, 2019

Thank you for reviewing and merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants