Update labels on Item flags 02 and 03 #2369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per Windower/POLUtils#25 I am not sure about naming (tho these match the labels used on BG-Wiki, and I think LSB too), opinions appreciated.
Collaborator
|
May as well update Flag00 while you're at it |
Contributor
Author
...how the duck do I name this? "Wallhanging"? "Can be hung on wall in Mog House"? "BEHOLD, A PAINTING"? |
Using `Wall-mounted` because that's what FFXIV calls these.
Contributor
Author
|
Decided to go with Wall-mounted because FFXIV uses that name and it felt appropriate. Can change it to "Wall Furnishing" if we prefer? |
z16
pushed a commit
that referenced
this pull request
Nov 4, 2024
* Update labels on Item flags 02 and 03 As per Windower/POLUtils#25 I am not sure about naming (tho these match the labels used on BG-Wiki, and I think LSB too), opinions appreciated. * Rename Flag00 to Wall-mounted. Using `Wall-mounted` because that's what FFXIV calls these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Windower/POLUtils#25
I am not sure about naming (tho these match the labels used on BG-Wiki, and I think LSB too), opinions appreciated.