Update send.lua #2345
Merged
Update send.lua #2345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial refactoring by Arcon
Tentative fix for a couple quirks caused by splitting the `target` arg off `...`
Added obligatory `<on|off>` argument to `@debug` Moved debug prints around for simplicity Fixed bugs: - a stray `:upper()` had survived the refactoring - a `@job` target that was different from the sender main job would be lost in the void and not passed on
z16
pushed a commit
that referenced
this pull request
Nov 4, 2024
* Update send.lua Initial refactoring by Arcon * Update send.lua Tentative fix for a couple quirks caused by splitting the `target` arg off `...` * Update send.lua Added obligatory `<on|off>` argument to `@debug` Moved debug prints around for simplicity Fixed bugs: - a stray `:upper()` had survived the refactoring - a `@job` target that was different from the sender main job would be lost in the void and not passed on * Update send.lua
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial refactoring by Arcon
Code cleanup and implementation of new encoding-aware string.split()