Update EmpyPopTracker to 2.7.0 #2221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z16
reviewed
Aug 20, 2022
| return { | ||
| has_all_pops = not nm.pops or T(nm.pops):all(function(item) | ||
| return item.type == 'item' and owns_item(item.id, items) or owns_key_item(item.id, key_items) | ||
| -- Avoids confusing item and key item IDs |
Member
There was a problem hiding this comment.
Am I missing something here? Or is this change meant to be cosmetic only? Because it should do the same thing as before.
Contributor
Author
There was a problem hiding this comment.
That's what I thought. There's an issue wherein, if the item.type is "item" but the owns_item returns false, it falls back to running the owns_key_item. This can give us a false positive when we have a matching key item ID.
Member
There was a problem hiding this comment.
Ah, that's a good point. Thanks for clarifying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add NMs:
Related to: