Update to properly handle more valid commands #2074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now will properly swap for valid commands such as `/ma "Garuda"<me>` and `/ma "Elemental Siphon"<me>` Also will now properly handle (ignore) more valid forms of waits such as `<wait>` and `<wait 1.2>` and waits that are not preceded by a space `/ma garuda <me><wait 2.2>`
Contributor
|
I still find the method used to handle the parsing problematic, I think its made clear by the comment on this line https://github.com/RubenatorX/Lua/blob/45ed71746eaab9b0004fc9e9c0d86ca790c8bea1/addons/GearSwap/triggers.lua#L58 we dont remove the |
z16
added a commit
that referenced
this pull request
Nov 4, 2024
Update to properly handle more valid commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now will properly swap for valid commands such as
/ma "Garuda"<me>and/ma "Elemental Siphon"<me>Also will now properly handle (ignore) more valid forms of waits such as
<wait>and<wait 1.2>and waits that are not preceded by a space
/ma garuda <me><wait 2.2>See discord #development discussion for additional context: https://discord.com/channels/338590234235371531/501099842097905675/880870405966024784