Added automatic creation of default.lua user profile #2025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality to resolve target IDs passed to commands in the chatlog, upon which the send command relies for the <tid> parameters to work, only works when gearswap has an user profile loaded and active. This leads to many complaints that the functionality is not working, simply because it's being used on a character without gearswap, or without a profile loaded. This change will make gearswap create an empty default.lua on load, which is sufficient for it to become active and start resolving target IDs. (I am not sure about the wording of the notice, and of the contents of the empty file. I am also not sure about the place - doing it on load feels the most appropriate. I'm open to suggestions on all of these.)
Collaborator
|
Potentially could have it make default only if it did not find another file to load otherwise. |
Contributor
Author
|
Closing this PR due to using a completely different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality to resolve target IDs passed to commands in the chatlog, upon which the send command relies for the parameters to work, only works when gearswap has an user profile loaded and active. This leads to many complaints that the functionality is not working, simply because it's being used on a character without gearswap, or without a profile loaded.
This change will make gearswap create an empty default.lua on load, which is sufficient for it to become active and start resolving target IDs.
(I am not sure about the wording of the notice, and of the contents of the empty file. I am also not sure about the place - doing it on load feels the most appropriate. I'm open to suggestions on all of these.)