Skip to content

Allow specifying a different render-quantum-size for an AudioContext or OfflineAudioContext#2469

Merged
padenot merged 3 commits into
mainfrom
13-user-selectable-render-size
Sep 22, 2023
Merged

Allow specifying a different render-quantum-size for an AudioContext or OfflineAudioContext#2469
padenot merged 3 commits into
mainfrom
13-user-selectable-render-size

Conversation

@padenot
Copy link
Copy Markdown
Member

@padenot padenot commented Feb 8, 2022 •
edited by pr-preview Bot
Loading

This fixes #13.

Without the heavy markup for now, this will come later.

This largely implements what was discussed.

Preview | Diff

@padenot padenot requested a review from hoch February 8, 2022 13:54
@padenot padenot self-assigned this Feb 8, 2022
@padenot
Copy link
Copy Markdown
Member Author

padenot commented Feb 8, 2022

It actually fixes #2450, I got confused because this got moved from the old v2 repo.

@hoch hoch mentioned this pull request Feb 14, 2022
Closed
hoch
hoch reviewed Mar 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I have a few comments.

Comment thread index.bs
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
@hoch
Copy link
Copy Markdown
Member

hoch commented Mar 15, 2022

The direction of this work looks great, but we (@hoch and @padenot representing Chrome and FireFox respectively) agreed that we don't have capacity to finish the actual implementation of this feature in 2022. We believe bringing the spec change when we don't have any implementations support it will confuse developers, so we decided to put this PR on hold until we have a plan for the actual engineering work.

@hoch hoch changed the title Allow specifying a different render-quantum-size for an AudioContext or OfflineAudioContext [On Hold] Allow specifying a different render-quantum-size for an AudioContext or OfflineAudioContext Mar 15, 2022
@orottier orottier mentioned this pull request Sep 2, 2022
Open
5 tasks
@hoch hoch added Priority: Urgent WG charter deliverables; "need to have". https://speced.github.io/spec-maintenance/about/ and removed recharter-deliverables Priority: Urgent WG charter deliverables; "need to have". https://speced.github.io/spec-maintenance/about/ labels Sep 14, 2022
@padenot padenot mentioned this pull request Dec 15, 2022
Closed
juj
juj reviewed Feb 25, 2023
View reviewed changes
Comment thread index.bs Outdated
hoch
hoch approved these changes Sep 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits.

Comment thread index.bs
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
@hoch hoch changed the title [On Hold] Allow specifying a different render-quantum-size for an AudioContext or OfflineAudioContext Allow specifying a different render-quantum-size for an AudioContext or OfflineAudioContext Sep 11, 2023
@padenot padenot force-pushed the 13-user-selectable-render-size branch from 8badf58 to d37ffcb Compare September 21, 2023 12:16
@padenot
Copy link
Copy Markdown
Member Author

padenot commented Sep 21, 2023

I've rebased this on top of the current main branch. I'll add the markup in a separate commit for clarity, the only functional changes are in the first commit.

@padenot padenot force-pushed the 13-user-selectable-render-size branch from d37ffcb to c3cbd7a Compare September 21, 2023 12:25
hoch
hoch approved these changes Sep 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM, but with two nits.

Comment thread index.bs Outdated
Comment thread index.bs Outdated
@padenot padenot merged commit 0c5f2df into main Sep 22, 2023
@hoch
Copy link
Copy Markdown
Member

hoch commented Sep 22, 2023

Thanks for working on this, @padenot!

@juj juj mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoch hoch hoch approved these changes

+1 more reviewer

@juj juj juj left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@padenot padenot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@padenot @hoch @juj