Skip to content
This repository was archived by the owner on Aug 22, 2022. It is now read-only.

Include node_modules in uploaded bundle#670

Merged
sbc100 merged 2 commits into
masterfrom
npm_install
Oct 10, 2020
Merged

Include node_modules in uploaded bundle#670
sbc100 merged 2 commits into
masterfrom
npm_install

Conversation

@sbc100
Copy link
Copy Markdown
Member

@sbc100 sbc100 commented Oct 9, 2020

This should allow the bundle to be used directly without running
npm install or npm ci as post-install step.

@sbc100 sbc100 requested a review from dschuff October 9, 2020 21:05
@sbc100
Copy link
Copy Markdown
Member Author

sbc100 commented Oct 9, 2020

@pfaffe

This should allow the bundle to be used directly without running
`npm install` or `npm ci` as post-install step.
Copy link
Copy Markdown
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like this increases package size by 30MB?

Do the packages still work if the user does npm ci?

I see the npm ci command here, but where are the node_modules files copied? Or do we copy a parent directory with all subchildren?

Comment thread src/build.py Outdated
@sbc100
Copy link
Copy Markdown
Member Author

sbc100 commented Oct 9, 2020

Sounds like this increases package size by 30MB?

Yes, but its saves each user from having to run npm ci on install .. which in turn saves at least (probably a fair bit more) in overall downloading,

Do the packages still work if the user does npm ci?

Yes, I believe users can always run this, even if we pre-seed the directory modules.

I see the npm ci command here, but where are the node_modules files copied? Or do we copy a parent directory with all subchildren?

The the command is run in em_install_dir which is the installed directed that is ultimately tar'd up.

@sbc100 sbc100 merged commit 2f7fcef into master Oct 10, 2020
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Oct 10, 2020
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Oct 10, 2020
@dschuff dschuff deleted the npm_install branch March 5, 2021 00:42
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 9, 2021
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 9, 2021
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 9, 2021
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 10, 2021
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 10, 2021
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 10, 2021
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 10, 2021
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants