gen-headers: Generate assertions of layout from witx#149
Merged
Conversation
28f0c0e to
f18d9f7
Compare
Collaborator
Author
|
The CI doesn't actually build the libc. I tested locally with wasi-sdk 7:
|
sunfishcode
reviewed
Dec 19, 2019
sbc100
approved these changes
Dec 19, 2019
sbc100
approved these changes
Dec 19, 2019
Member
sbc100
left a comment
There was a problem hiding this comment.
Output: lgtm
Rust code: i have not idea what i'm doing
b31f958 to
4c110bc
Compare
so that generate-libc command works
e89609a to
ad230b4
Compare
Collaborator
Author
|
Well, apparently I forgot to merge this right after returning for the new year, and it got out-of-date. I just rebased on master, pointed at the current wasi master, and regenerated header. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serves as evidence that WebAssembly/WASI#181 is correct