This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Spec binary format#383
Merged
Merged
Conversation
Contributor
|
Is it intentional or an oversight that this PR disregards #372 and the discussion that happened there? Also, is now outdated (since it's an unmodified line, the review tool won't let me put a comment there). |
Member
Author
Since that isn't resolved yet, but I wanted to make progress with the spec, I did it based on the old opcodes for now. It's easily changed once #372 is finalised.
Thanks, updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this does not yet take #372 into consideration, i.e., uses the temporary opcodes for now.