Put f32.const before f64.const, for consistency.#696
Closed
sunfishcode wants to merge 3 commits intobinary_0xcfrom
Closed
Put f32.const before f64.const, for consistency.#696sunfishcode wants to merge 3 commits intobinary_0xcfrom
sunfishcode wants to merge 3 commits intobinary_0xcfrom
Conversation
…686) * Clarify that wasm may be viewed as either an AST or a stack machine. * Reword the introductory paragraph. * Add parens, remove "typed".
Make opcode 0x00 `unreachable`, and move `nop` to a non-zero opcode. All-zeros is one of the more common patterns of corrupted data. This change makes it more likely that code that is accidentally zeroed, in whole or in part, will be noticed when executed rather than silently running through a nop slide. Obviously, this doesn't matter when an opcode table is present, but if there is a default opcode table, it would presumably use the opcodes defined here.
Member
|
lgtm |
Member
|
I'm fine with all the changes you have suggested so far. But instead of making many tiny changes individually, how about a single comprehensive PR for reorganising the opcode space? That would help seeing the big picture and not fragmenting the discussion. |
|
Shall we do this in 0xD? |
Member
|
Should be subsumed by #826 now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for the binary_0xc branch, and is one step of a broader opcode reorganization.