add check for empty block in fluid sigil placement, and waterlogging#2167
Open
Phil-M-H wants to merge 1 commit intoWayofTime:1.20.1from
Open
add check for empty block in fluid sigil placement, and waterlogging#2167Phil-M-H wants to merge 1 commit intoWayofTime:1.20.1from
Phil-M-H wants to merge 1 commit intoWayofTime:1.20.1from
Conversation
Contributor
Author
|
To be clear, issue #1862 still exists in the latest versions (I accidentally broke an end portal frame on a server I was hosting because I right-clicked on the side of an eye of ender), I just dug up the issue so it could be closed out. |
Contributor
|
I've been adding to the changelog because its usually just me and thus everything is in order and github shouldnt be whining about there being mismatches. also theres the changelog.txt and the changelog book entry which should both be updated at the same time. It would be easier for us if you removed the changelog entry and we'll add it ourselves once we merge it |
971abbe to
ba90f19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I edited the changelog as well since I saw some other PRs do that -- just let me know if you'd prefer I don't touch that.