[feat] CORS 구현 완료#91
Merged
Merged
Conversation
Walkthrough보안 설정이 강화되어 CORS 지원이 추가 및 구성되었습니다. 모든 오리진, GET/POST/PUT/DELETE/OPTIONS 메서드, 모든 헤더, 인증정보 허용 등으로 CORS가 전역 경로에 적용됩니다. "/admin/**" 경로는 인증 없이 접근이 허용되도록 변경되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Server (Spring Security)
participant CORS Config
Client->>Server (Spring Security): HTTP Request (e.g., OPTIONS, GET)
Server (Spring Security)->>CORS Config: Apply CORS rules
alt Request matches "/admin/**"
Server (Spring Security)-->>Client: Allow without authentication
else
Server (Spring Security)->>Client: Apply normal security rules
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/com/wayble/server/common/config/SecurityConfig.java(3 hunks)
🔇 Additional comments (2)
src/main/java/com/wayble/server/common/config/SecurityConfig.java (2)
16-20: CORS 관련 import 추가 확인완료표준 Spring Framework CORS 기능을 위한 적절한 import문들입니다.
38-38: CORS 설정 통합 확인완료Spring Security 필터 체인에 CORS 설정이 올바르게 통합되었습니다.
| "/index", | ||
| "/index.html" | ||
| "/index.html", | ||
| "/admin/**" |
There was a problem hiding this comment.
관리자 경로에 대한 인증 없는 접근 허용 - 보안 위험
"/admin/**" 경로를 permitAll()에 추가하면 관리자 기능에 인증 없이 접근할 수 있게 됩니다. 이는 심각한 보안 위험을 초래할 수 있습니다.
관리자 경로는 적절한 인증과 권한 검증이 필요합니다.
다음과 같이 수정하는 것을 권장합니다:
- "/admin/**"그리고 관리자 경로에 대한 별도의 보안 설정을 추가하세요:
.requestMatchers("/admin/**").hasRole("ADMIN")🤖 Prompt for AI Agents
In src/main/java/com/wayble/server/common/config/SecurityConfig.java at line 53,
remove "/admin/**" from the permitAll() matcher list to prevent unauthenticated
access to admin paths. Instead, add a separate security rule that restricts
access to "/admin/**" by requiring the user to have the "ADMIN" role using
.requestMatchers("/admin/**").hasRole("ADMIN"). This ensures proper
authentication and authorization for admin routes.
There was a problem hiding this comment.
@KiSeungMin 알겠습니다! 보안 이슈이니 나중에 놓치지 않도록 GitHub 이슈로 등록해드릴까요? 관리자 경로 보안 강화에 대한 follow-up 작업으로 추적하면 좋을 것 같습니다.
필요하시면 말씀해 주세요! 🙂
Comment on lines
+62
to
+73
| @Bean | ||
| public CorsConfigurationSource corsConfigurationSource() { | ||
| CorsConfiguration configuration = new CorsConfiguration(); | ||
| configuration.setAllowedOriginPatterns(Arrays.asList("*")); // 모든 오리진 허용 | ||
| configuration.setAllowedMethods(Arrays.asList("GET", "POST", "PUT", "DELETE", "OPTIONS")); // 허용할 HTTP 메서드 | ||
| configuration.setAllowedHeaders(Arrays.asList("*")); // 모든 헤더 허용 | ||
| configuration.setAllowCredentials(true); // 쿠키, 인증 정보 허용 | ||
|
|
||
| UrlBasedCorsConfigurationSource source = new UrlBasedCorsConfigurationSource(); | ||
| source.registerCorsConfiguration("/**", configuration); // 모든 경로에 적용 | ||
| return source; | ||
| } |
There was a problem hiding this comment.
과도하게 허용적인 CORS 설정 - 중대한 보안 위험
현재 CORS 설정이 매우 관대하여 보안 위험을 초래할 수 있습니다:
- 모든 오리진 허용 + 인증정보 허용: CSRF 공격에 취약
- 모든 헤더 및 메서드 허용: 공격 표면 확대
- 운영 환경에 부적합: 개발 환경에서만 사용해야 할 설정
다음과 같이 더 제한적인 설정으로 변경하는 것을 권장합니다:
- configuration.setAllowedOriginPatterns(Arrays.asList("*")); // 모든 오리진 허용
+ configuration.setAllowedOriginPatterns(Arrays.asList("http://localhost:3000", "https://yourdomain.com")); // 특정 오리진만 허용
- configuration.setAllowedMethods(Arrays.asList("GET", "POST", "PUT", "DELETE", "OPTIONS")); // 허용할 HTTP 메서드
+ configuration.setAllowedMethods(Arrays.asList("GET", "POST", "PUT", "DELETE", "OPTIONS")); // 필요한 메서드만 허용
- configuration.setAllowedHeaders(Arrays.asList("*")); // 모든 헤더 허용
+ configuration.setAllowedHeaders(Arrays.asList("Authorization", "Content-Type", "X-Requested-With")); // 필요한 헤더만 허용또는 환경별로 다른 설정을 사용하도록 프로파일을 구성하세요.
🤖 Prompt for AI Agents
In src/main/java/com/wayble/server/common/config/SecurityConfig.java lines 62 to
73, the CORS configuration is overly permissive by allowing all origins with
credentials, all headers, and all methods, which poses serious security risks.
To fix this, restrict allowed origins to specific trusted domains instead of
"*", limit allowed HTTP methods to only those necessary, and avoid allowing
credentials unless absolutely required. Additionally, configure different CORS
settings for development and production environments using Spring profiles to
ensure secure defaults in production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✔️ 연관 이슈
📝 작업 내용
스크린샷 (선택)
Summary by CodeRabbit