Skip to content

[FIX] 웨이블 마커 및 polyline 수정#156

Merged
zyovn merged 3 commits into
developfrom
feature/jeongbin
Aug 17, 2025
Merged

[FIX] 웨이블 마커 및 polyline 수정#156
zyovn merged 3 commits into
developfrom
feature/jeongbin

Conversation

@zyovn

@zyovn zyovn commented Aug 17, 2025

Copy link
Copy Markdown
Member

✔️ 연관 이슈

📝 작업 내용

웨이블 마커 경사로, 엘리베이터, 없음으로 수정
polyline 위도, 경도 순서 수정

스크린샷 (선택)

image

Summary by CodeRabbit

  • 버그 수정
    • 경로 폴리라인 좌표 표현을 위도,경도(lat,lon) 순서로 일관화하여 지도에 경로가 뒤집히거나 어긋나던 문제를 해결했습니다.
    • 중복 좌표 제거가 정확히 적용되어 경로가 끊기지 않고 매끄럽게 표시됩니다.
    • 외부 지도/내비게이션 서비스와의 좌표 해석 호환성이 향상되어 공유·내보내기 시 오류가 감소합니다.
    • 사용자 위치 및 경로 표시의 정확도가 전반적으로 개선되었습니다.

@zyovn zyovn self-assigned this Aug 17, 2025
@zyovn zyovn added the 🛠️ fix 기능 오류 및 코드 개선이 필요한 곳 수정 label Aug 17, 2025
@coderabbitai

coderabbitai Bot commented Aug 17, 2025

Copy link
Copy Markdown

Walkthrough

폴리라인 생성 로직에서 좌표 배열 순서가 전역적으로 [경도, 위도] → [위도, 경도]로 변경되었고, 엣지에 geometry가 있는 경우에도 각 좌표를 [위도, 경도]로 변환하여 중복 제거 로직에 전달하도록 수정되었습니다.

Changes

Cohort / File(s) Summary
Polyline 좌표 순서 변경
src/main/java/com/wayble/server/direction/service/WaybleDijkstraService.java
폴리라인 좌표 순서를 [lon,lat]에서 [lat,lon]로 변경. 엣지 geometry 경로에서도 각 coords를 [coords[1], coords[0]]로 재배열하여 deleteDuplicateCoords에 전달하도록 수정. 퍼블릭 시그니처 변경 없음.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Assessment against linked issues

Objective Addressed Explanation
폴리라인 위도, 경도 순서 수정 (#155)
웨이블 마커 경사로/엘리베이터/없음으로 수정 (#155) 마커 관련 코드 변경(아이콘/타입 매핑 등)이 PR 내에 없음.

Possibly related PRs

Suggested labels

🐛 bug fix

Suggested reviewers

  • hyoinYang

Poem

폴리라인 위를 폴짝 걷는 토끼,
위도 먼저 외치며 좌표를 정리하네.
중복은 쓱, 순서는 딱, 지도 위 깔끔히—
바람 따라 경로 이어가네. 🐇🗺️

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e09c69a and 9ee9175.

📒 Files selected for processing (1)
  • src/main/java/com/wayble/server/direction/service/WaybleDijkstraService.java (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/main/java/com/wayble/server/direction/service/WaybleDijkstraService.java
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/jeongbin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@seung-in-Yoo seung-in-Yoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!!

@zyovn zyovn merged commit 8a57a53 into develop Aug 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🛠️ fix 기능 오류 및 코드 개선이 필요한 곳 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants