-
Notifications
You must be signed in to change notification settings - Fork 1
[refactor] 대중교통 길찾기 api 관련 리팩토링 #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
def26d2
[fix] 길찾기 api 사용시 토큰이 필요하도록 수정
hyoinYang 7c53b70
[fix] POST로 변경
hyoinYang 482f59a
[refactor] edge의 빌더 accessLevel 축소
hyoinYang 7811fdf
[feat] Discord Webhook 에러 알림 기능 구현
KiSeungMin 73cee64
[chore] log.debug -> info로 수정
KiSeungMin 8f013ae
[fix] GET에서 POST로 변경
hyoinYang 8b13e96
[refactor] Nullable 이용
hyoinYang 0778e07
[refactor] 디버깅 메시지를 log로 변경
hyoinYang 29ab83d
[feat] Discord Webhook 에러 알림 기능 구현
KiSeungMin 632d878
[refactor] 오타, 빠진 필드 수정, 디버깅 메시지 삭제
hyoinYang 20b6563
[fix] JPA userId 매핑을 위한 명시적 칼럼 name 추가
seung-in-Yoo a9a3ef9
[test] workflow 임시 수정
seung-in-Yoo 7b8d6fa
[fix] JPA Lazy Loading, No Session 문제 해결
seung-in-Yoo 618212a
[test] workflow 원상 복구
seung-in-Yoo 19801dd
[fix] 배포 서버에서 로그인,유저 정보 조회 관련 에러 해결
KiSeungMin 30b4c7a
[refactor] webconfig 이용
hyoinYang 35135ef
[refactor] 직선거리 30km 이상일 경우 바로 반환
hyoinYang c2b8c9f
Merge remote-tracking branch 'origin/develop' into feature/hyoin
hyoinYang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 0 additions & 14 deletions
14
src/main/java/com/wayble/server/common/config/RestTemplateConfig.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
src/main/java/com/wayble/server/common/dto/DiscordWebhookPayload.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package com.wayble.server.common.dto; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| public record DiscordWebhookPayload( | ||
| String content, | ||
| List<Embed> embeds | ||
| ) { | ||
| public record Embed( | ||
| String title, | ||
| String description, | ||
| String timestamp, | ||
| List<Field> fields | ||
| ) { | ||
| public record Field(String name, String value, boolean inline) {} | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
src/main/java/com/wayble/server/direction/external/kric/KricProperties.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package com.wayble.server.direction.external.kric; | ||
|
|
||
| import org.springframework.boot.context.properties.ConfigurationProperties; | ||
|
|
||
| @ConfigurationProperties(prefix = "kric.api") | ||
| public record KricProperties( | ||
| String key, | ||
| String baseUrl | ||
| ) { | ||
| } |
2 changes: 1 addition & 1 deletion
2
...rection/dto/toilet/KricToiletRawBody.java → .../external/kric/dto/KricToiletRawBody.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...rection/dto/toilet/KricToiletRawItem.java → .../external/kric/dto/KricToiletRawItem.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...ion/dto/toilet/KricToiletRawResponse.java → ...ernal/kric/dto/KricToiletRawResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 5 additions & 2 deletions
7
src/main/java/com/wayble/server/direction/repository/FacilityRepository.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,12 @@ | ||
| package com.wayble.server.direction.repository; | ||
|
|
||
| import com.wayble.server.direction.entity.transportation.Facility; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface FacilityRepository extends JpaRepository<Facility, Long> { | ||
| import java.util.List; | ||
| import java.util.Optional; | ||
|
|
||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface FacilityRepository extends JpaRepository<Facility, Long> { | ||
| Optional<Facility> findByNodeId(Long nodeId); | ||
| } |
21 changes: 0 additions & 21 deletions
21
src/main/java/com/wayble/server/direction/service/EdgeService.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
RestTemplate을 빈으로 주입받는 것을 권장
RestTemplate을 직접 인스턴스화하는 대신 빈으로 주입받으면 테스트 용이성과 설정 관리가 개선됩니다.
생성자나
@Autowired를 통해 주입받거나, WebClient 사용을 고려해보세요. PR 목적에서 WebClient 도입을 언급했으므로 일관성을 위해 여기서도 WebClient 사용이 적절할 수 있습니다.🤖 Prompt for AI Agents