Fix for: boolean values converted to strings instead of numbers#20
Open
bfil wants to merge 1 commit intoWantworthy:masterfrom
Open
Fix for: boolean values converted to strings instead of numbers#20bfil wants to merge 1 commit intoWantworthy:masterfrom
bfil wants to merge 1 commit intoWantworthy:masterfrom
Conversation
Member
|
This is a great fix, I'm going to pull this in for the next major update to dynode as this changes the way data is stored. I also have to add in some details to the readme about boolean handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boolean values should be converted to numbers on DynamoDB, in this way we can have the following item with boolean properties:
And it can be retrieved and tested in the following way:
Because in Javascript (and many other languages):