RND-19109: Add buyer_seller to python sdk#559
Merged
FenderStrat85 merged 4 commits intomasterfrom Mar 9, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds buyer/seller filtering support to the Cargo Movements search endpoint in the Python SDK, and extends the CargoMovement trade schema/fixtures to include buyer/seller metadata.
Changes:
- Add
filter_buyer/filter_sellerandexclude_buyer/exclude_sellerparameters toCargoMovements.search(). - Extend
CargoMovementTradeEntryto include buyer/seller-related fields (e.g.,buyer_id,seller_id,contract_type,delivery_method). - Update cargo movement fixtures and flattening tests to cover the new trade fields.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
vortexasdk/endpoints/cargo_movements.py |
Adds buyer/seller filter + exclude parameters and passes them through to the API request. |
vortexasdk/api/cargo_movement.py |
Extends the trade entry model with buyer/seller metadata fields and related Literal types. |
tests/endpoints/test_cargo_movements_real.py |
Adds real-API tests for buyer/seller filtering and exclusion. |
tests/api/test_cargo_movement.py |
Updates model/flattening expectations to include new trade fields. |
tests/api/examples/cargo_movements.json |
Extends example payload with buyer/seller fields on a trade entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jack-bliss
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELATED TICKETS
! Do not post related PRs here, unless they are open source !
CHANGELOG
TESTS
COMMENTS