Skip to content

RND-19109: Add buyer_seller to python sdk#559

Merged
FenderStrat85 merged 4 commits intomasterfrom
rnd-19109
Mar 9, 2026
Merged

RND-19109: Add buyer_seller to python sdk#559
FenderStrat85 merged 4 commits intomasterfrom
rnd-19109

Conversation

@FenderStrat85
Copy link
Contributor

RELATED TICKETS

! Do not post related PRs here, unless they are open source !

CHANGELOG

  • Add buyer/seller filters to sdk

TESTS

  • Test buyer/seller filters and exclusions are working correctly

COMMENTS

  • any other business

Copilot AI review requested due to automatic review settings March 4, 2026 18:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds buyer/seller filtering support to the Cargo Movements search endpoint in the Python SDK, and extends the CargoMovement trade schema/fixtures to include buyer/seller metadata.

Changes:

  • Add filter_buyer/filter_seller and exclude_buyer/exclude_seller parameters to CargoMovements.search().
  • Extend CargoMovementTradeEntry to include buyer/seller-related fields (e.g., buyer_id, seller_id, contract_type, delivery_method).
  • Update cargo movement fixtures and flattening tests to cover the new trade fields.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
vortexasdk/endpoints/cargo_movements.py Adds buyer/seller filter + exclude parameters and passes them through to the API request.
vortexasdk/api/cargo_movement.py Extends the trade entry model with buyer/seller metadata fields and related Literal types.
tests/endpoints/test_cargo_movements_real.py Adds real-API tests for buyer/seller filtering and exclusion.
tests/api/test_cargo_movement.py Updates model/flattening expectations to include new trade fields.
tests/api/examples/cargo_movements.json Extends example payload with buyer/seller fields on a trade entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@FenderStrat85 FenderStrat85 marked this pull request as draft March 5, 2026 19:55
@FenderStrat85 FenderStrat85 marked this pull request as ready for review March 9, 2026 15:27
@FenderStrat85 FenderStrat85 merged commit 8164bfc into master Mar 9, 2026
11 of 12 checks passed
@FenderStrat85 FenderStrat85 deleted the rnd-19109 branch March 9, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants